feat(multi format schema): support new media types #569
Conversation
- application/raml+yaml;version=1.0 - application/vnd.google.protobuf;version=2 - application/vnd.google.protobuf;version=3 - application/xml
Pakisan
requested review from
GreenRover,
asyncapi-bot-eve,
char0n,
dalelane,
derberg,
fmvilas,
jonaslagoni and
smoya
as code owners
|
| "application/vnd.google.protobuf;version=2", | ||
| "application/vnd.google.protobuf;version=3", | ||
|
|
||
| "application/xml" |
There was a problem hiding this comment.
do we need it here? in the end, it works without it listed here right? in the spec xml is not listed in the list of recommeneded schemas - and also, it is anyway just recommended
There was a problem hiding this comment.
Yep, otherwise here will be error
asyncapi: 3.0.0
info:
title: Account Service
version: 1.0.0
description: This service is in charge of processing user signups
channels:
userSignedUp:
address: user/signedup
messages:
UserSignedUp:
$ref: '#/components/messages/userSignedUp'
operations:
sendUserSignedUp:
action: send
channel:
$ref: '#/channels/userSignedUp'
messages:
- $ref: '#/channels/userSignedUp/messages/UserSignedUp'
components:
messages:
userSignedUp:
payload:
schemaFormat: application/xml
schema: |
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified">
<xs:element name="User">
<xs:complexType>
<xs:sequence>
<xs:element name="displayName" type="xs:string">
<xs:annotation>
<xs:documentation>Name of the user</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="email" type="xs:string">
<xs:annotation>
<xs:documentation>Email of the user</xs:documentation>
</xs:annotation>
</xs:element>
</xs:sequence>
</xs:complexType>
</xs:element>
</xs:schema>There was a problem hiding this comment.
it is anyway just recommended
Yep, it's recommendation. But folks from Specmatic already have scenarios where they are using .xsd as payload schema
Without proper registration UI component will not work because of error in our parser
Error thrown during AsyncAPI document parsing. Name: Error, message: Unknown schema format
There was a problem hiding this comment.
I have already checked this changes
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
2 participants
Closes asyncapi/jasyncapi#214
Let's left them like ref, string or object. Generally idk which schema will represent them correctly